> On Aug 31, 2020, at 7:37 AM, Elliott Mitchell <ehem+...@m5p.com> wrote: > > On Fri, Aug 28, 2020 at 09:24:41AM +0200, Jan Beulich wrote: >> On 28.08.2020 04:57, Elliott Mitchell wrote: >>> Subdirectories which have .gitignore files should not be referenced in >>> the global .gitignore files. Move several lines to appropriate subdirs. >>> >>> Signed-off-by: Elliott Mitchell <ehem+...@m5p.com> >>> >>> --- >>> Hopefully the commit message covers it. When moved to the subdirectories >>> I'm using "./<file>" as otherwise any file sharing the name in a deeper >>> subdirectory would be subject to the match. >> >> May I ask why this last sentence isn't part of the commit message? > > My thinking is it was pretty straightforward to figure out when looking. > Not /quite/ obvious enough to avoid commenting in e-mail, but not quite > obscure enough to have in commit message. This can go either way really.
Storing the extra paragraph in git is cheap; trying to reconstruct why someone made a change 10 years after the fact is often difficult. Probably not worth a re-send — it can be moved into the commit message by the committer; but if you’re going to send v2 anyway, might as well move it in. -George
