On Tue, Jul 21, 2020 at 08:13:28AM +0100, Paul Durrant wrote:
> > -----Original Message-----
> > From: Nick Rosbrook <rosbro...@gmail.com>
> > Sent: 21 July 2020 00:55
> > To: xen-devel@lists.xenproject.org
> > Cc: p...@xen.org; Nick Rosbrook <rosbro...@ainfosec.com>; George Dunlap
> > <george.dun...@citrix.com>;
> > Ian Jackson <ian.jack...@eu.citrix.com>; Wei Liu <w...@xen.org>
> > Subject: [PATCH for-4.14] golang/xenlight: fix code generation for python
> > 2.6
> >
> > Before python 2.7, str.format() calls required that the format fields
> > were explicitly enumerated, e.g.:
> >
> > '{0} {1}'.format(foo, bar)
> >
> > vs.
> >
> > '{} {}'.format(foo, bar)
> >
> > Currently, gengotypes.py uses the latter pattern everywhere, which means
> > the Go bindings do not build on python 2.6. Use the 2.6 syntax for
> > format() in order to support python 2.6 for now.
> >
> > Signed-off-by: Nick Rosbrook <rosbro...@ainfosec.com>
>
> I'm afraid this is too late for 4.14 now. We are in hard freeze, so only
> minor docs changes or critical bug fixes are being taken at
> this point.
I will apply this to staging. This can be backported later if we care
about CentOS 6 (EOL Nov this year) or any other old distros that still
run python 2.6.
FAOD Nick is one of the maintainers of golang code so I think his SoB is
good enough for this simple patch. It looks obviously correct to me.
Wei.
