On 21/07/2020 08:13, Paul Durrant wrote:
>> -----Original Message-----
>> From: Nick Rosbrook <rosbro...@gmail.com>
>> Sent: 21 July 2020 00:55
>> To: xen-devel@lists.xenproject.org
>> Cc: p...@xen.org; Nick Rosbrook <rosbro...@ainfosec.com>; George Dunlap
>> <george.dun...@citrix.com>;
>> Ian Jackson <ian.jack...@eu.citrix.com>; Wei Liu <w...@xen.org>
>> Subject: [PATCH for-4.14] golang/xenlight: fix code generation for python 2.6
>>
>> Before python 2.7, str.format() calls required that the format fields
>> were explicitly enumerated, e.g.:
>>
>> '{0} {1}'.format(foo, bar)
>>
>> vs.
>>
>> '{} {}'.format(foo, bar)
>>
>> Currently, gengotypes.py uses the latter pattern everywhere, which means
>> the Go bindings do not build on python 2.6. Use the 2.6 syntax for
>> format() in order to support python 2.6 for now.
>>
>> Signed-off-by: Nick Rosbrook <rosbro...@ainfosec.com>
> I'm afraid this is too late for 4.14 now. We are in hard freeze, so only
> minor docs changes or critical bug fixes are being taken at
> this point.
This is Reported-by me, and breaking gitlab CI on the master and 4.14
branches (because apparently noone else cares to look at the results...)
The alternative is to pull support for CentOS 6 from the 4.14 release,
which would best be done by a commit taking out the C6 containers from CI.
~Andrew
