On 31/03/2020 15:41, Jan Beulich wrote: > On 31.03.2020 12:05, Andrew Cooper wrote: >> To simplify future cleanup, rename this variable. >> >> No functional change. >> >> Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> > Acked-by: Jan Beulich <jbeul...@suse.com> > >> @@ -438,7 +437,7 @@ static struct microcode_patch >> *cpu_request_microcode(const void *buf, >> unsigned int cpu = smp_processor_id(); >> const struct cpu_signature *sig = &per_cpu(cpu_sig, cpu); >> >> - if ( bufsize < 4 || >> + if ( size < 4 || >> *(const uint32_t *)buf != UCODE_MAGIC ) > Take the opportunity and put this on a single line?
I have actually done that in a later patch. This was introduced in patch 1, so I'll fix there and rebase it throughout the series. ~Andrew
