On 08/02/2020 12:12, Julien Grall wrote: > Hi Andrew, > > On 05/02/2020 16:50, Andrew Cooper wrote: >> diff --git a/xen/arch/arm/hvm.c b/xen/arch/arm/hvm.c >> index 76b27c9168..f3426f37fe 100644 >> --- a/xen/arch/arm/hvm.c >> +++ b/xen/arch/arm/hvm.c >> @@ -46,7 +46,8 @@ long do_hvm_op(unsigned long op, >> XEN_GUEST_HANDLE_PARAM(void) arg) >> if ( copy_from_guest(&a, arg, 1) ) >> return -EFAULT; >> - if ( a.index >= HVM_NR_PARAMS ) >> + if ( a.index >= HVM_NR_PARAMS || >> + a.index == HVM_PARAM_PAE_ENABLED ) >> return -EINVAL; > > For the small Arm part: > > Acked-by: Julien Grall <jul...@xen.org> >
So it turns out that, in light of "xen/hvm: Fix handling of obsolete HVM_PARAMs", there is even more breakage here, because it is *only* the libxc code which causes the params to be rejected on ARM. I'm clearly going to have to sink rather more time into this than I was initially intending, so I'll dust off my earlier series and sort this who mess out, once and for all. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
