On 06.02.2020 12:32, Andrew Cooper wrote: > On 06/02/2020 09:28, Jan Beulich wrote: >> On 05.02.2020 17:50, Andrew Cooper wrote: >>> --- a/xen/include/public/hvm/params.h >>> +++ b/xen/include/public/hvm/params.h >>> @@ -86,7 +86,7 @@ >>> #define HVM_PARAM_STORE_PFN 1 >>> #define HVM_PARAM_STORE_EVTCHN 2 >>> >>> -#define HVM_PARAM_PAE_ENABLED 4 >>> +#define HVM_PARAM_PAE_ENABLED 4 /* Obsolete. Do not use. */ >> I think this should be moved up in the deprecated section. > > There isn't a deprecated section. > > The params are currently sorted numerically. Playing "which param is > this integer?" with an unsorted params.h is an experience I wish never > to repeat again.
You'll find /* These parameters are deprecated and their meaning is undefined. */ near the top of the file. I can see your concern about the file not being sorted, but it already isn't. The alternative then is to frame each deprecated param by #ifdef __XEN__ - I'd be okay with that if that's preferred by you. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
