On Fri, Dec 27, 2019 at 01:45:16PM +0000, Andrew Cooper wrote: > The call to xc_domain_disable_migrate() is made only from x86, while its > handling in Xen is common. Move it to the libxl__build_pre(). > > hvm_set_conf_params(), hvm_set_viridian_features(), > hvm_set_mca_capabilities(), and the altp2m logic is all in common > code (parts ifdef'd) but despite this, is all actually x86 specific. > > Move it into x86 specific code, and fold all of the xc_hvm_param_set() calls > together into hvm_set_conf_params() in a far more coherent way. > > Finally - ensure that all hypercalls have their return values checked. > > No practical change in constructed domains. Fewer useless hypercalls now to > construct an ARM guest. > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com>
I'm fine with moving the code. AIUI Arm guests also need to set at least one hvm param for callback vector, but that's already handled in libxl_arm.c. As far as I can tell the code is correct, there is no code in between the moved code that depends on some of the fields being set in a specific order, so: Acked-by: Wei Liu <w...@xen.org> Wei. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
