On 27.12.2019 14:45, Andrew Cooper wrote: > The call to xc_domain_disable_migrate() is made only from x86, while its > handling in Xen is common. Move it to the libxl__build_pre(). > > hvm_set_conf_params(), hvm_set_viridian_features(), > hvm_set_mca_capabilities(), and the altp2m logic is all in common > code (parts ifdef'd) but despite this, is all actually x86 specific. > > Move it into x86 specific code, and fold all of the xc_hvm_param_set() calls > together into hvm_set_conf_params() in a far more coherent way. > > Finally - ensure that all hypercalls have their return values checked. > > No practical change in constructed domains. Fewer useless hypercalls now to > construct an ARM guest. > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> > --- > CC: Ian Jackson <ian.jack...@citrix.com> > CC: Wei Liu <w...@xen.org> > CC: Anthony Perard <anthony.per...@citrix.com> > CC: Jan Beulich <jbeul...@suse.com> > CC: Wei Liu <w...@xen.org> > CC: Roger Pau Monné <roger....@citrix.com> > CC: Stefano Stabellini <sstabell...@kernel.org> > CC: Julien Grall <jul...@xen.org> > CC: Volodymyr Babchuk <volodymyr_babc...@epam.com> > --- > tools/libxl/libxl_dom.c | 183 > ++---------------------------------------------- > tools/libxl/libxl_x86.c | 181 ++++++++++++++++++++++++++++++++++++++++++++++-
I'll defer to the tool stack maintainers here. Imo this file would better be split - one to contain stuff better falling under x86 maintainership, and the other for everything falling in the tool stack realm. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
