On 11/15/19 7:44 PM, Nick Rosbrook wrote: > diff --git a/tools/golang/xenlight/Makefile b/tools/golang/xenlight/Makefile > index 0987305224..681f32c234 100644 > --- a/tools/golang/xenlight/Makefile > +++ b/tools/golang/xenlight/Makefile > @@ -7,20 +7,21 @@ GOCODE_DIR ?= $(prefix)/share/gocode/ > GOXL_PKG_DIR = /src/$(XEN_GOCODE_URL)/xenlight/ > GOXL_INSTALL_DIR = $(GOCODE_DIR)$(GOXL_PKG_DIR) > > -# PKGSOURCES: Files which comprise the distributed source package > -PKGSOURCES = xenlight.go > - > GO ?= go > > .PHONY: all > all: build > > .PHONY: package > -package: $(XEN_GOPATH)$(GOXL_PKG_DIR)$(PKGSOURCES) > +package: $(XEN_GOPATH)$(GOXL_PKG_DIR) > > -$(XEN_GOPATH)/src/$(XEN_GOCODE_URL)/xenlight/$(PKGSOURCES): $(PKGSOURCES) > +$(XEN_GOPATH)/src/$(XEN_GOCODE_URL)/xenlight/: %.gen.go
Sorry to come back to this... I think this would be better explicitly listing out the files that are needed. As I said, the current way of doing things means gengotypes.py will *always* be re-run; and the result, when experimenting with the `typeof` before, was that my local changes to helpes.gen.py were being overwritten. Having this be `xenlight.go types.gen.go helpers.gen.go` instead means 1) gengotypes is only run when one of its inputs changes 2) you can make local changes to the generated files and have them copied over 3) The copying only happens when one of the above two things happens 4) The final compile is slightly faster because the go compiler knows that the files hasn't changed. I can change this on check-in if you're OK with it, and I end up checking part of the series in before you send v3. -George _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
