> -----Original Message----- > From: Andrew Cooper <andrew.coop...@citrix.com> > Sent: 13 September 2019 17:04 > To: Xen-devel <xen-devel@lists.xenproject.org> > Cc: Andrew Cooper <andrew.coop...@citrix.com>; Jan Beulich > <jbeul...@suse.com>; Wei Liu <w...@xen.org>; > Roger Pau Monne <roger....@citrix.com>; Paul Durrant <paul.durr...@citrix.com> > Subject: [PATCH] x86/viridian: Reword HV_X64_MSR_CRASH_CTL print message > > Message such as: > > (XEN) d3v0 VIRIDIAN CRASH: 51 1 ffff9700e146b000 1000 204 > > have confused many people into thinking the the problem is a bug in the > viridian code. The prefix was intended to signify the use of the viridian > crash-reporting interface. > > Replace the VIRIDIAN prefix with 'reported' to reduce the confusion to > non-xen-developers trying to interpret the message.
This is a message that is peculiar to Windows VMs, so how about "Windows VM CRASH"? Paul > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> > --- > CC: Jan Beulich <jbeul...@suse.com> > CC: Wei Liu <w...@xen.org> > CC: Roger Pau Monné <roger....@citrix.com> > CC: Paul Durrant <paul.durr...@citrix.com> > > This wants backporting to every stable tree which has viridian crash interface > support. > --- > xen/arch/x86/hvm/viridian/viridian.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/arch/x86/hvm/viridian/viridian.c > b/xen/arch/x86/hvm/viridian/viridian.c > index 4b06b78a27..f98c8e7753 100644 > --- a/xen/arch/x86/hvm/viridian/viridian.c > +++ b/xen/arch/x86/hvm/viridian/viridian.c > @@ -357,7 +357,7 @@ int guest_wrmsr_viridian(struct vcpu *v, uint32_t idx, > uint64_t val) > d->shutdown_code = SHUTDOWN_crash; > spin_unlock(&d->shutdown_lock); > > - gprintk(XENLOG_WARNING, "VIRIDIAN CRASH: %lx %lx %lx %lx %lx\n", > + gprintk(XENLOG_WARNING, "reported CRASH: %lx %lx %lx %lx %lx\n", > vv->crash_param[0], vv->crash_param[1], vv->crash_param[2], > vv->crash_param[3], vv->crash_param[4]); > break; > -- > 2.11.0 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
