On 02.09.19 13:06, Jan Beulich wrote:
On 27.08.2019 14:40, Juergen Gross wrote:
On 27.08.19 14:37, Andrew Cooper wrote:
On 27/08/2019 11:59, Juergen Gross wrote:
+static void *
+sched_idle_alloc_vdata(const struct scheduler *ops, struct vcpu *v,
+ void *dd)
+{
+ /* Any non-NULL pointer is fine here. */
+ return (void *)1UL;
As an observation, the vdata interface (and others, if applicable) could
do with being updated to use ERR_PTR(), just as done in c/s 340edc390
One of the items for my scheduler cleanup patches.
Passing 1 back here is rather dangerous.
Not really. vdata is scheduler specific, and the idle-scheduler doesn't
use it.
But maybe handing back e.g. ZERO_BLOCK_PTR would still be better?
Not the least because of avoiding an open-coded cast?
Yes. I wasn't aware of its existance.
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
