On 27/08/2019 11:59, Juergen Gross wrote:
> +static void *
> +sched_idle_alloc_vdata(const struct scheduler *ops, struct vcpu *v,
> +                       void *dd)
> +{
> +    /* Any non-NULL pointer is fine here. */
> +    return (void *)1UL;

As an observation, the vdata interface (and others, if applicable) could
do with being updated to use ERR_PTR(), just as done in c/s 340edc390

Passing 1 back here is rather dangerous.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Reply via email to