On Tue, Jun 04, 2019 at 06:47:32PM +0100, Ian Jackson wrote:
> Anthony PERARD writes ("[PATCH 9/9] libxl_disk: Implement missing timeout for
> libxl_cdrom_insert"):
> > Since the previous patch "libxl_disk: Use ev_qmp in libxl_cdrom_insert",
> > there are no kind of timeout anymore, add one back.
>
> Hrm. The patch itself looks good, so
>
> Acked-by: Ian Jackson <ian.jack...@eu.citrix.com>
>
> But I wonder if this could somehow be placed earlier to preserve
> bisectability.
I think it would be possible to place the patch right after "libxl_disk:
Cut libxl_cdrom_insert into steps", even though the timeout will never
get a chance to actually fire. (Before "Use ev_qmp ...", everything is
synchronous.)
--
Anthony PERARD
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
