>>> On 22.05.19 at 14:20, <julien.gr...@arm.com> wrote: > > On 21/05/2019 10:55, Julien Grall wrote: >> Hi Jan, >> >> On 5/21/19 10:43 AM, Jan Beulich wrote: >>>>>> On 21.05.19 at 11:35, <julien.gr...@arm.com> wrote: >>>> On 5/21/19 10:26 AM, Jan Beulich wrote: >>>>>>>> On 20.05.19 at 20:12, <julien.gr...@arm.com> wrote: >>>>>> As this is now Xen and tools only, I am wondering whether the >>>>>> check on >>>>>> GNU_C is still necessary. I am happy to send a follow-up patch (or >>>>>> fold >>>>>> in this one) if it can be removed. >>>>> >>>>> I think this should be dropped if it can be without breaking any >>>>> part of the build. >>>> This is because all the tools are part of xen.git, right? >>> >>> Right - no-one else is supposed to define __XEN_TOOLS__, or >>> if anyone does, they're on their own. >> >> Thanks for the information. I will do a full build check. > > I thought about this again, long term there are an attempt to build xen with > other compiler not necessarily supporting GNU C extension. > While this would probably not be the only place that need to be reworked, we > would have to revert part of this change. So I will not drop the #ifdef here.
Well, I don't know how it is for Arm, but on x86 we actually use the "extended" naming quite extensively, so building with a compiler that doesn't support this extension is not really an option there. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
