On 21/05/2019 10:55, Julien Grall wrote:
Hi Jan,
On 5/21/19 10:43 AM, Jan Beulich wrote:
On 21.05.19 at 11:35, <julien.gr...@arm.com> wrote:
On 5/21/19 10:26 AM, Jan Beulich wrote:
On 20.05.19 at 20:12, <julien.gr...@arm.com> wrote:
As this is now Xen and tools only, I am wondering whether the check on
GNU_C is still necessary. I am happy to send a follow-up patch (or fold
in this one) if it can be removed.
I think this should be dropped if it can be without breaking any
part of the build.
This is because all the tools are part of xen.git, right?
Right - no-one else is supposed to define __XEN_TOOLS__, or
if anyone does, they're on their own.
Thanks for the information. I will do a full build check.
I thought about this again, long term there are an attempt to build xen with
other compiler not necessarily supporting GNU C extension.
While this would probably not be the only place that need to be reworked, we
would have to revert part of this change. So I will not drop the #ifdef here.
I will resend the patch next week to give some time for more feedback.
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
