On 10/04/2019 09:28, Paul Durrant wrote: > Again, digging back in mail... > > ----- > [From Jan] >> + case MSR_IA32_BNDCFGS: >> + if ( !is_hvm_domain(d) || !cp->feat.mpx || >> + !hvm_set_guest_bndcfgs(v, val) ) >> + goto gp_fault; > In both cases the is_hvm_*() check looks to be redundant, as > for PV guests cp->feat.mpx can't be set. Personally I'd prefer > this to be an ASSERT() instead, but I'd listen to Andrew (as > the main author of this code) saying otherwise.
In this case, the compiler/linkers opinion in the shim build does provide a very clear answer. The check is not redundant and must remain. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
