On 14/03/2019 11:47, Jan Beulich wrote: >>>> On 14.03.19 at 11:14, <andrew.coop...@citrix.com> wrote: >> You do know that mfn_add(mfn, -1) will DTRT? > It will, but imo it looks slightly odd in particular in e.g. > for ( ...; ...; mfn_add(mfn, -1) ), hence I didn't suggest it. But > I don't object either.
Well - in mathematics, x - 1 is identical to x + (-1), so the construct doesn't look overly odd to me. Alternatively, we could rename mfn_add to something else, but nothing comes to mind which would be as clear. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
