>>> On 14.02.19 at 14:10, <nmant...@amazon.de> wrote:
> On 2/12/19 14:08, Jan Beulich wrote:
>>>>> On 08.02.19 at 14:44, <nmant...@amazon.de> wrote:
>>> @@ -955,22 +967,22 @@ long evtchn_bind_vcpu(unsigned int port, unsigned int
>>> vcpu_id)
>>> {
>>> case ECS_VIRQ:
>>> if ( virq_is_global(chn->u.virq) )
>>> - chn->notify_vcpu_id = vcpu_id;
>>> + chn->notify_vcpu_id = v->vcpu_id;
>>> else
>>> rc = -EINVAL;
>>> break;
>>> case ECS_UNBOUND:
>>> case ECS_INTERDOMAIN:
>>> - chn->notify_vcpu_id = vcpu_id;
>>> + chn->notify_vcpu_id = v->vcpu_id;
>>> break;
>>> case ECS_PIRQ:
>>> - if ( chn->notify_vcpu_id == vcpu_id )
>>> + if ( chn->notify_vcpu_id == v->vcpu_id )
>>> break;
>>> unlink_pirq_port(chn, d->vcpu[chn->notify_vcpu_id]);
>>> - chn->notify_vcpu_id = vcpu_id;
>>> + chn->notify_vcpu_id = v->vcpu_id;
>> Right now we understand why all of these changes are done, but
>> without a comment this is liable to be converted back as an
>> optimization down the road.
>
> I will extend the commit message accordingly.
Actually the request was for a comment addition, not for a commit
message adjustment.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
