>>> On 19.10.18 at 16:28, <wei.l...@citrix.com> wrote: > @@ -548,10 +550,14 @@ ENTRY(ret_from_intr) > GET_CURRENT(bx) > testb $3, UREGS_cs(%rsp) > jz restore_all_xen > +#ifdef CONFIG_PV > movq VCPU_domain(%rbx), %rax > cmpb $0, DOMAIN_is_32bit_pv(%rax) > je test_all_events > jmp compat_test_all_events > +#else > + BUG > +#endif
Hmm, not sure here (and elsewhere): Another option is to streamline execution by replacing the conditional branch with an unconditional one in the !PV case. Andrew, do you have any thoughts either way? > @@ -596,8 +602,9 @@ ENTRY(common_interrupt) > cmovnz %r12, %r15 > cmovnz %r12d, %ebx > .Lintr_cr3_okay: > - > +#ifdef CONFIG_PV > CR4_PV32_RESTORE > +#endif Couldn't you instead make the macro expand to nothing? Also please don't remove the blank line. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
