On Fri, Oct 19, 2018 at 05:09:43PM +0100, Andrew Cooper wrote: > On 19/10/18 15:28, Wei Liu wrote: > > Put the code in smpboot.c under CONFIG_PV. Not that we don't need to > > set up a stub here because entry.S already does that. > > > > Signed-off-by: Wei Liu <wei.l...@citrix.com> > > The stub isn't the purpose of the code. This code is to switch between > SYS_DESC_trap_gate and SYS_DESC_irq_gate depending on whether we're > intending to use XPTI. All other details in the IDT entry are already > configured correctly for int80_direct_trap. > > The patch is fine, but with an tweaked commit message, Reviewed-by: > Andrew Cooper <andrew.coop...@citrix.com>
I have updated the commit message to the following: The code snippet is to switch between SYS_DECS_trap_gate and SYS_DESC_irq_gate depending on whether XPTI is used. When PV is disabled there is no need to switch. Does that look OK to you? Wei. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
