On 26/10/2018 14:31, Jan Beulich wrote:
>>>> On 15.10.18 at 12:36, <andrew.coop...@citrix.com> wrote:
>> --- a/xen/arch/x86/domain.c
>> +++ b/xen/arch/x86/domain.c
>> @@ -323,6 +323,18 @@ void free_vcpu_struct(struct vcpu *v)
>> free_xenheap_page(v);
>> }
>>
>> +/* Initialise various registers to their architectural INIT/RESET state. */
>> +void arch_vcpu_regs_init(struct vcpu *v)
>> +{
>> + v->arch.user_regs = (typeof(v->arch.user_regs)){
>> + .rflags = X86_EFLAGS_MBS,
>> + };
> Sadly this initializer broke the build once again for gcc 4.3.x.
Oh - that's unfortunate. I guess it will need a memset instead.
> (As a side note, using .eflags instead of .rflags would have a
> fair chance of an omitted REX prefix.)
You specifically requested rflags over eflags in your previous review.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
