On 09/14/2018 01:29 PM, Dario Faggioli wrote: > On Fri, 2018-09-14 at 09:45 +0100, Jan Beulich wrote: >>>>> On 13.09.18 at 18:51, <dfaggi...@suse.com> wrote: >>> I fully agree with and second George's reasoning, and feel 100% >>> like >>> providing my: >>> >>> Acked-by: Dario Faggioli <dfaggi...@suse.com> >> >> And that's despite "sched=credit2 crashes system when using >> cpupools"? >> > Well, considering that, as you say, there's a fix on the mailing list > already, yes. > > And I'm guessing George must feel kind of the same, as he sent this > patch, before reviewing/committing the other.
Well, also because our team had just done our retrospective and noted the state of credit2 (and I think Ian brought it up on IRC). It was either "do it now" or "put it on a list to be done soon"; and my "list of things to be done soon" is already too long. :-) > In fact, the sooner we switch, the earlier OSSTest will start use > Credit2 for everything, and show us whether or not there are other > issues. And, speaking about that specific bug, OSSTest does not [sic!] > test cpupools, so it's not even like it'll block pushes. > > That being said... > >> While I agree that we shouldn't delay the switch for >> much longer, in particular with there already being a fix available >> from you I think that one should go in before the one here. >> > ... I'm fine if maintainers/committers feels like waiting for the other > patch to go in. The order in which they're committed, is something I > have no control on. I don't think it's strictly necessary for this > patch and the fix to hit the repo in a particular order. But if others > do, no problem. I feel the same way: I don't see any reason to delay, but I don't think it's worth pressing the point when it's just a few days. -George _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
