On Friday, 14 September 2018 6:45:35 PM AEST Jan Beulich wrote: > >>> On 13.09.18 at 18:51, <dfaggi...@suse.com> wrote: > > On Thu, 2018-09-13 at 17:38 +0100, George Dunlap wrote: > >> Credit2 was declared "supported" in 4.8, and as of 4.10 had two other > >> critical features implemented (soft affinity / NUMA and caps). > >> > >> [..] > >> > >> Credit2, like credit, has a number of workloads / setups for which > >> performance could be improved. Personally I think networking and > >> partially-loaded systems is going to be more representative of what > >> Xen is actually used for; so I think credit2 is on the whole the > >> better scheduler to use by default. And in any case, making those > >> improvements on credit2 will be easier than on credit. > >> > >> Signed-off-by: George Dunlap <george.dun...@citrix.com> > > > > After all the effort we've spent on this, I'm really, really happy to > > see this (trying to) happen. Thanks for sending the patch. :-) > > > > I fully agree with and second George's reasoning, and feel 100% like > > providing my: > > > > Acked-by: Dario Faggioli <dfaggi...@suse.com> > > And that's despite "sched=credit2 crashes system when using > cpupools"? While I agree that we shouldn't delay the switch for > much longer, in particular with there already being a fix available > from you I think that one should go in before the one here.
Even though my opinion probably isn't very heavy on this matter, I've used credit2 exclusively for a considerable time. If you're talking the issue I think you're talking about, then I discovered it when doing stuff that most people probably wouldn't bother with - evidenced that I hadn't done it before either. I take peoples word on the performance +/- of a few percent here and there - so if its easier to maintain and better code, then yeah - it makes sense to move on with it. I certainly haven't found any normal use cases that would lead me to object to this. -- Steven Haigh 📧 net...@crc.id.au 💻 https://www.crc.id.au 📞 +61 (3) 9001 6090 📱 0412 935 897
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
