On 03/09/18 17:03, Jan Beulich wrote: >> --- a/xen/common/domain.c >> +++ b/xen/common/domain.c >> @@ -272,8 +272,12 @@ struct domain *domain_create(domid_t domid, >> if ( (d = alloc_domain_struct()) == NULL ) >> return ERR_PTR(-ENOMEM); >> >> + /* Sort out our idea of is_system_domain(). */ >> d->domain_id = domid; >> >> + /* Debug sanity. */ >> + ASSERT(is_system_domain(d) ? config == NULL : config != NULL); > Would you mind shortening this to at least > > ASSERT(is_system_domain(d) ? !config : config); > > while you move it?
Unfortunately not. domain.c: In function ‘domain_create’: domain.c:296:67: error: pointer/integer type mismatch in conditional expression [-Werror] ASSERT(is_system_domain(d) ? !config : config); ^ cc1: all warnings being treated as errors /local/xen.git/xen/Rules.mk:194: recipe for target 'domain.o' failed which reminds me why I wrote it the way I did originally. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
