On Mon, Sep 03, 2018 at 03:46:56PM +0100, Andrew Cooper wrote: > Given two subtle failures from getting this wrong before, and more cleanup on > the way, move the setting of d->guest_type as early as possible. > > Note that despite moving the assignment of d->guest_type outside of the > is_idle_domain(d) check, it still behaves the same. Previously, system > domains had no direct assignment of d->guest_type and behaved as PV guests > because guest_type_pv has the value 0. > > While tidying up the predicate, leave a comment refering to > is_system_domain(), and move the associated ASSERT() to be beside the > asignment. > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com>
Reviewed-by: Wei Liu <wei.l...@citrix.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
