Re: [XEN PATCH v2 3/3] eclair: add deviations of MISRA C Rule 5.5

[Jan Beulich]

On 16.07.2025 18:04, Dmytro Prokopchuk1 wrote:
> 
> 
> On 7/15/25 13:50, Jan Beulich wrote:
>> On 15.07.2025 12:07, Dmytro Prokopchuk1 wrote:
>>> ARM only are:
>>> -config=MC3A2.R5.5,reports+={deliberate,
>>> "any_area(all_loc(file(^xen/include/xen/bitops\\.h$)))"}
>>
>> This one's probably fine.
>>
>>> -config=MC3A2.R5.5,reports+={deliberate,
>>> "all_area(decl(name(parse_gnttab_limit))||macro(name(parse_gnttab_limit)))"}
>>> -config=MC3A2.R5.5,reports+={deliberate,
>>> "all_area(decl(name(update_gnttab_par))||macro(name(update_gnttab_par)))"}
>>
>> These two look too broad: They're affecting common/grant_table.c only, aren't
>> they?
>>
>>> -config=MC3A2.R5.5,reports+={deliberate,
>>> "all_area(decl(name(pirq_cleanup_check))||macro(name(pirq_cleanup_check)))"}
>>
>> This one also looks overly broad, but it's perhaps unavoidable to be that 
>> way.
> 
> Those deviations can be narrowed (specifying file name):
> 
> -config=MC3A2.R5.5,reports+={deliberate, 
> "any_area(any_loc(file(^xen/include/xen/bitops\\.h$)) && 
> macro(name(__test_and_set_bit||__test_and_clear_bit||__test_and_change_bit||test_bit)))"}
> -config=MC3A2.R5.5,reports+={deliberate, 
> "any_area(any_loc(file(^xen/common/grant_table\\.c$))&&macro(name(update_gnttab_par||parse_gnttab_limit)))"}
> -config=MC3A2.R5.5,reports+={deliberate, 
> "any_area(any_loc(file(^xen/include/xen/irq\\.h$))&&macro(name(pirq_cleanup_check)))"}
> 
> Are you OK with it?

This looks acceptable to me, yes.

Jan