Jan, I don't mind, you can adjust it. Please, go ahead.
On 7/10/25 12:44, Dmytro Prokopchuk wrote: > Yes, sure. I'll update commit message. > Thanks! > > On 7/10/25 11:21, Jan Beulich wrote: >> On 09.07.2025 23:38, Dmytro Prokopchuk1 wrote: >>> Address a violation of MISRA C:2012 Rule 5.5: >>> "Identifiers shall be distinct from macro names". >>> >>> Reports for service MC3A2.R5.5: >>> xen/drivers/passthrough/iommu.c: non-compliant macro 'iommu_quarantine' >>> xen/include/xen/iommu.h: non-compliant variable 'iommu_quarantine' >>> >>> There is a clash between function name and macro. >>> Add an 'extern' declaration for 'iommu_quarantine' >>> under the same preprocessor condition (#ifdef CONFIG_HAS_PCI). >> >> Perhaps s/Add an/Put the/ or some such? You don't add any declaration, >> after all. >> >>> This ensures that the declaration is consistent >>> and only exposed when CONFIG_HAS_PCI is defined. >>> >>> Signed-off-by: Dmytro Prokopchuk <dmytro_prokopch...@epam.com> >> >> With some suitable adjustment (happy to make while committing as long as >> you agree): >> Reviewed-by: Jan Beulich <jbeul...@suse.com> >> >> Jan >
