Hi Michal.

>> +    if ( base >= limit )
> Given that limit is exclusive, to prevent empty regions, you would need to 
> check
> for base >= (limit - 1), even though it's not really possible because today we
> require page aligned addresses (limit must be at least bigger or equal than 
> base
> + PAGE_SIZE). That said, it can change one day, so I would suggest to modify 
> the
> check. With that:
> 
> Reviewed-by: Michal Orzel <michal.or...@amd.com>
> 
> ~Michal
> 

I think that this one is maybe also fine as-is?

Cheers,
Hari

Reply via email to