Re: [PATCH v1 04/16] arm/vpl011: use raw spin_lock_{irqrestore,irqsave}

[Orzel, Michal]

On 24/06/2025 07:46, Jan Beulich wrote:
> On 24.06.2025 05:55, dm...@proton.me wrote:
>> From: Denis Mukhin <dmuk...@ford.com> 
>>
>> Replace VPL011_{LOCK,UNLOCK} macros with raw spinlock calls to improve
>> readability.
> 
> I'm not an Arm maintainer, so I have limited say here, but: How is this
> improving readability? It better utilizes available local variables, yes,
> so this may be a little bit of an optimization, but otherwise to me this
> looks to rather hamper readability.
I agree with Jan here. I don't think it improves readability, therefore I don't
think such change is needed.

~Michal