On 17/06/2025 13:12, Ayan Kumar Halder wrote:
> prepare_selector(), read_protection_region() and write_protection_region()
> differ significantly between arm32 and arm64. Thus, move these functions
> to their sub-arch specific folder.
>
> Also the macro GENERATE_{WRITE/READ}_PR_REG_CASE are moved, in order to
> keep them in the same file of their usage and improve readability.
>
> Signed-off-by: Ayan Kumar Halder <ayan.kumar.hal...@amd.com>
> Reviewed-by: Luca Fancellu <luca.fance...@arm.com>
> ---
> Changes from -
>
> v2 - New patch introduced in v3.
>
> v3 - 1. Add Luca's R-b.
>
> xen/arch/arm/mpu/Makefile | 1 +
> xen/arch/arm/mpu/arm64/Makefile | 1 +
> xen/arch/arm/mpu/arm64/mm.c | 130 ++++++++++++++++++++++++++++++++
> xen/arch/arm/mpu/mm.c | 117 ----------------------------
> 4 files changed, 132 insertions(+), 117 deletions(-)
> create mode 100644 xen/arch/arm/mpu/arm64/Makefile
> create mode 100644 xen/arch/arm/mpu/arm64/mm.c
>
> diff --git a/xen/arch/arm/mpu/Makefile b/xen/arch/arm/mpu/Makefile
> index 808e3e2cb3..5ad15e93be 100644
> --- a/xen/arch/arm/mpu/Makefile
> +++ b/xen/arch/arm/mpu/Makefile
> @@ -1,4 +1,5 @@
> obj-$(CONFIG_ARM_32) += domain-page.o
> +obj-$(CONFIG_ARM_64) += arm64/
I think this should be above domain-page given alphabetical sorting.
Acked-by: Michal Orzel <michal.or...@amd.com>
~Michal
