On Thu, Mar 27, 2025 at 03:59:16PM -0700, Stefano Stabellini wrote: > I was suggesting to create a file under /tmp instead to keep the source > directory cleaner,
There's an easy way to keep the source directory *extra clean* when doing hypervisor build, like we are doing here for randoconfig, that is: out-of-tree build! > and also because I don't think it is an issue to add > files to /tmp and not clean them because they get removed when the > container exits. Isn't it the case? Locally it looks like each > containers gets its own /tmp that is cleaned after exit. Sorry, I tend to think that those script could be use outside of the CI or containers, and /tmp can have a lot of different configuration, so it's better to clean after oneself when possible. As for running containers locally, maybe it's faster to reuse a container instead of creating a new one from an image, which mean /tmp is probably not cleaned on exit. But I guess people usuasly do `docker run --rm` or use `containerize` which does the same. > So my preference is to use mktemp and *not* clean the tmp file on exit. > > If you think we have to clean the tmp file on exit, then let's go with > your xen/allrandom.config.tmp approach as I would prefer to avoid the > "trap" command to keep the sources simpler. So, is that an Ack on my original patch? Cheers, -- Anthony Perard | Vates XCP-ng Developer XCP-ng & Xen Orchestra - Vates solutions web: https://vates.tech
