We should avoid changing files from the source tree if we don't intend to commit the result.
We don't really need to check if $EXTRA_FIXED_RANDCONFIG is empty so add it to the temporary file in all cases. Signed-off-by: Anthony PERARD <anthony.per...@vates.tech> --- automation/scripts/build | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/automation/scripts/build b/automation/scripts/build index 522efe774e..8a3b8fb6b2 100755 --- a/automation/scripts/build +++ b/automation/scripts/build @@ -12,12 +12,12 @@ $cc --version # random config or default config if [[ "${RANDCONFIG}" == "y" ]]; then - # Append job-specific fixed configuration - if [[ -n "${EXTRA_FIXED_RANDCONFIG}" ]]; then - echo "${EXTRA_FIXED_RANDCONFIG}" >> xen/tools/kconfig/allrandom.config - fi + cp -f xen/tools/kconfig/allrandom.config xen/allrandom.config.tmp - make -j$(nproc) -C xen KCONFIG_ALLCONFIG=tools/kconfig/allrandom.config randconfig + # Append job-specific fixed configuration + echo "${EXTRA_FIXED_RANDCONFIG}" >> xen/allrandom.config.tmp + + make -j$(nproc) -C xen KCONFIG_ALLCONFIG=allrandom.config.tmp randconfig # RANDCONFIG implies HYPERVISOR_ONLY HYPERVISOR_ONLY="y" -- Anthony Perard | Vates XCP-ng Developer XCP-ng & Xen Orchestra - Vates solutions web: https://vates.tech