On 17.01.2025 01:31, Stefano Stabellini wrote: > On Wed, 1 Mar 2023, Jan Beulich wrote: >> While we want certain things turned off in shim-exclusive mode, doing >> so via "depends on !PV_SHIM_EXCLUSIVE" badly affects allyesconfig: Since >> that will turn on PV_SHIM_EXCLUSIVE, other options will be turned off as >> a result. Yet allyesconfig wants to enable as much of the functionality >> as possible. >> >> Retain PV_SHIM_EXCLUSIVE as a prompt-less option such that first of all >> C code using it can remain as is. This isn't just for less code churn, >> but also because I think that symbol is more logical to use in many >> (all?) places. >> >> Requested-by: Andrew Cooper <andrew.coop...@citrix.com> >> Signed-off-by: Jan Beulich <jbeul...@suse.com> >> >> --- >> The new Kconfig control's name is up for improvement suggestions, but I >> think it's already better than the originally thought of >> FULL_HYPERVISOR. > > I think the approach in general is OK, maybe we can improve the naming > further. What about one of the following? > > NO_PV_SHIM_EXCLUSIVE > PV_SHIM_NOT_EXCLUSIVE > ADD_PV_SHIM > PV_SHIM_AND_HYPERVISOR > > This is because I think the option should be tied to PV_SHIM. Keep in > mind that users are supposed to be able to use "make menuconfig" and > pick good options based on the menu. An option called UNCONSTRAINED or > FULL_HYPERVISOR or any other name that has nothing to do with PV_SHIM is > very confusing to me.
Hmm. That was actually something I was specifically trying to avoid. Imo the connection to the shim only wants making in the help text. And I fear I view all your naming suggestions as hard to grok. Jan
