On 06.01.2025 21:16, Denis Mukhin wrote: > On Monday, January 6th, 2025 at 1:19 AM, Jan Beulich <jbeul...@suse.com> > wrote: >> On 04.01.2025 06:31, Denis Mukhin wrote: >>> On Monday, December 16th, 2024 at 7:04 AM, Jan Beulich jbeul...@suse.com >>> wrote: >>>> On 06.12.2024 05:42, Denis Mukhin via B4 Relay wrote: >>>> >>>>> + depends on HVM && HAS_IOPORTS >>>> >>>> Why HAS_IOPORTS? >>> >>> It is meant to highlight the fact that MMIO-based UART is not supported. >>> It is not currently possible to enable the emulator for, say, Arm platforms. >> >> >> That I guessed, yet you realize that HAS_IOPORTS describes a host property, >> not (so much) a guest one? > > re: host property: yes; this is meant to be only a guardrail for porting of > the > emulator code (if any) to other architectures, since there's no MMIO-based > NS16550 emulator yet. > > I will drop this superfluous dependency in the next iteration.
Just to clarify: If properly justified, I'm okay with the dependency to be kept. Otoh the lack of MMIO handling will turn out as pretty obvious if someone was to try to enable this emulation on an IO-port-less arch. Jan
