On 04.01.2025 04:07, Denis Mukhin wrote: > On Tuesday, December 10th, 2024 at 7:02 AM, Jan Beulich <jbeul...@suse.com> > wrote: >> On 06.12.2024 05:41, Denis Mukhin via B4 Relay wrote: >>> +int console_set_owner(domid_t domid) >> >> >> static? Iirc Misra doesn't like non-static functions which aren't called >> from any other CU. > > Yes, but there's a follow on patch which will undo static - > hwdom_crashconsole= > patch - to drop the user to xen console once dom0 has crashed. > So since there's a need in globally visible symbol, I decided to get rid of > static > right away.
Yet you realize that any series may go in piecemeal, and therefore no Misra rule may be violated at any patch boundary? Jan
