On 04.01.2025 03:57, Denis Mukhin wrote: > On Tuesday, December 10th, 2024 at 6:27 AM, Jan Beulich <jbeul...@suse.com> > wrote: >> On 06.12.2024 05:41, Denis Mukhin via B4 Relay wrote: >> >>> Introduce new printk() variant for convenient printouts which skip '(XEN)' >>> prefix on xen console. This is needed for the case when physical console is >>> owned by a domain w/ in-hypervisor UART emulation enabled. >> >> >> Imo it should still be guest_printk() which is then used from there. > > I ended up w/ printk_noprefix(): vprintk_common() expects user-defined prefix, > while original printk_common() does not expect prefix. Such inconsistency > may be confusing because both functions are named xxx_common().
Your reply at best partly addresses my comment: I didn't suggest a new name for the new function, but I rather suggested that you use an existing one instead. Jan
