Re: [PATCH v2 10/11] xen/bitops: Implement hweight64() in terms of hweight{l,32}()

[Jan Beulich]

On 29.08.2024 00:03, Andrew Cooper wrote:
> --- a/xen/include/xen/bitops.h
> +++ b/xen/include/xen/bitops.h
> @@ -331,6 +331,14 @@ static always_inline attr_const unsigned int 
> hweight32(uint32_t x)
>      return hweightl(x);
>  }
>  
> +static always_inline attr_const unsigned int hweight64(uint64_t x)

Same remark here as for the previous patch.

> +{
> +    if ( BITS_PER_LONG == 64 )

This can be >=, can't it?

With the adjustments:
Reviewed-by: Jan Beulich <jbeul...@suse.com>

Without:
Acked-by: Jan Beulich <jbeul...@suse.com>

Jan