On 29.08.2024 00:03, Andrew Cooper wrote: > --- a/xen/include/xen/bitops.h > +++ b/xen/include/xen/bitops.h > @@ -326,6 +326,11 @@ static always_inline attr_const unsigned int > hweightl(unsigned long x) > #endif > } > > +static always_inline attr_const unsigned int hweight32(uint32_t x)
See my question/remark on the earlier patch: I think we want to be consistent with always-inline functions and const/pure attributes. Since elsewhere we omit it, I think it should be omitted here, too. Jan
