On 20.08.2024 13:52, Samuel Thibault wrote:
> Juergen Gross, le mar. 13 août 2024 15:41:56 +0200, a ecrit:
>> In x86 mm code there are multiple instances of page table walks for
>> different purposes.
>>
>> Introduce a generic page table walker being able to cover the current
>> use cases. It will be used for other cases in future, too.
>>
>> The page table walker needs some per-level data, so add a table for
>> that data. Merge it with the already existing pt_prot[] array.
>>
>> Rewrite get_pgt() to use the new walker.
>>
>> Signed-off-by: Juergen Gross <jgr...@suse.com>
> 
> Reviewed-by: SAmuel Thibault <samuel.thiba...@ens-lyon.org>

Samuel - I've taken the liberty to convert the odd upper-case A.

Jürgen - looking at the mini-os short-log is quite odd, and increasingly
so. In the mini-os repo surely all commits are about mini-os; the
subject prefixes are kind of pointless. To nevertheless identify such
patches on xen-devel@, may I suggest to use (taking this patch as an
example) "[PATCH MINI-OS] mm: introduce generic page table walk function"
instead (or, of course, whatever variation thereof you may like better)?

Jan

Reply via email to