Re: [PATCH v2 3/3] mini-os: mm: convert set_readonly() to use walk_pt()

[Jürgen Groß]

On 20.08.24 14:53, Jan Beulich wrote:

On 20.08.2024 13:57, Samuel Thibault wrote:

Juergen Gross, le mar. 13 août 2024 15:41:58 +0200, a ecrit:

+    if ( ro->count == L1_PAGETABLE_ENTRIES )
+    {
+         ro->count = 0;
+         if ( HYPERVISOR_mmu_update(mmu_updates, ro->count, NULL,
+                                    DOMID_SELF) < 0 )

You need to set ro->count *after* calling mmu_update.

Happy to move the line while committing, so long as Jürgen agrees.

Oh yes, of course I do.

Thanks,


Juergen

OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

OpenPGP_signature.asc
Description: OpenPGP digital signature