On 25/06/18 13:17, Jan Beulich wrote: > We must not leave a vCPU with CR0.TS clear when it is not in fully eager > mode and has not touched non-lazy state. Instead of adding a 3rd > invocation of stts() to vcpu_restore_fpu_eager(), consolidate all of > them into a single one done at the end of the function. > > Rename the function at the same time to better reflect its purpose, as > the patches touches all of its occurences anyway. > > The new function parameter is not really well named, but > "need_stts_if_not_fully_eager" seemed excessive to me.
Perhaps put this in a comment beside the declaration/definition? For future people reading this code, its more useful there than in the commit message? Either way, Reviewed-by: Andrew Cooper <andrew.coop...@citrix.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
