On 20/06/2024 1:10 pm, Jan Beulich wrote:
> On 20.06.2024 13:14, Andrew Cooper wrote:
>> [ This is a minimal backport of commit 71cacfb035f4 ("x86/cpuid: Fix handling
>> of XSAVE dynamic leaves") to fix the bugs without depending on large
>> rework of
>> XSTATE handling in Xen 4.19 ]
>>
>> First, if XSAVE is available in hardware but not visible to the guest, the
>> dynamic leaves shouldn't be filled in.
>>
>> Second, the comment concerning XSS state is wrong. VT-x doesn't manage
>> host/guest state automatically, but there is provision for "host only" bits
>> to
>> be set, so the implications are still accurate.
>>
>> In Xen 4.18, no XSS states are supported, so it's safe to keep deferring to
>> real hardware.
>>
>> Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com>
> Reviewed-by: Jan Beulich <jbeul...@suse.com>
>
> I'll try to not forget to include this in my next backporting batch. Thanks
> for getting this sorted so quickly.
No problem. If you're intending to commit this, could you fix:
"depending on large" => "depending on the large"
in the first sentence please. Only just spotted it.
~Andrew
