On 13.05.2024 15:40, Elias El Yandouzi wrote: > From: Hongyan Xia <hongy...@amazon.com> > > When we do not have a direct map, archs_mfn_in_direct_map() will always > return false, thus init_node_heap() will allocate xenheap pages from an > existing node for the metadata of a new node. This means that the > metadata of a new node is in a different node, slowing down heap > allocation. > > Since we now have early vmap, vmap the metadata locally in the new node. > > Signed-off-by: Hongyan Xia <hongy...@amazon.com> > Signed-off-by: Julien Grall <jgr...@amazon.com> > Signed-off-by: Elias El Yandouzi <elias...@amazon.com> > > ---- > > Changes in v2: > * vmap_contig_pages() was renamed to vmap_contig() > * Fix indentation and coding style > > Changes from Hongyan's version: > * arch_mfn_in_direct_map() was renamed to > arch_mfns_in_direct_map() > * Use vmap_contig_pages() rather than __vmap(...). > * Add missing include (xen/vmap.h) so it compiles on Arm > > diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c > index dfb2c05322..3c0909f333 100644 > --- a/xen/common/page_alloc.c > +++ b/xen/common/page_alloc.c
Just one thing on top of what Roger has said: This being the only file that is touched, why "x86/setup:" as the subject prefix. It'll misguide people to assume x86 code is what is (mainly) being touched, unless they actually look into and scroll through the patch. Jan
