On 13.05.2024 15:40, Elias El Yandouzi wrote: > From: Hongyan Xia <hongy...@amazon.com> > > Create a per-domain mapping of PV guest_root_pt as direct map is being > removed. > > Note that we do not map and unmap root_pgt for now since it is still a > xenheap page. > > Signed-off-by: Hongyan Xia <hongy...@amazon.com> > Signed-off-by: Julien Grall <jgr...@amazon.com> > Signed-off-by: Elias El Yandouzi <elias...@amazon.com> > > ---- > Changes in V3: > * Rename SHADOW_ROOT > * Haven't addressed the potentially over-allocation issue as I don't > get it
I thought I had explained in enough detail that the GDT/LDT area needs quite a bit more space (2 times 64k per vCPU) than the root PT one (4k per vCPU). Thus while d->arch.pv.gdt_ldt_l1tab really needs to point at a full page (as long as not taking into account dynamic domain properties), d->arch.pv.root_pt_l1tab doesn't need to (and hence might better be allocated using xzalloc() / xzalloc_array(), even when also not taking into account dynamic domain properties, i.e. vCPU count). Jan