On 16.04.2024 11:15, Fouad Hilly wrote: > Refactor microcode_update() hypercall by adding flags field. > Introduce XENPF_microcode_update2 hypercall to handle flags field. > struct xenpf_microcode_update updated to have uint32_t flags at > the end of the sturcture. > > [v2] > 1- Update message description to highlight interface change. > 2- Removed extra empty lines. > 3- removed unnecessary define. > 4- Corrected long lines. > 5- Removed ternary operator. > 6- Introduced static ucode_update_flags, which will be used later to > determine local ucode_force_flag.
Non-style comments on v1 have remained un-addressed. Specifically, to give an example, while 1 says you now highlight the interface change, the request was to explain why changing an existing structure is okay (hint: it likely isn't, as the structure size changes for compat [aka 32-bit] callers). I'm not going to give the same comments again; I'll rather expect you to respond to them by either adjustments to the patch (or its description), or by verbal replies. Jan
