On 16.04.2024 11:15, Fouad Hilly wrote:
> Refactor xen-ucode tool by adding usage() to handle usage\help messages
> As we add more command options this will keep help\usage messages in common
> block
>
> [v2]
> 1- Improved message description.
> 2- Fixed formatting and indentation.
> 3- Error message to print to stderr.
I can't spot any use of stderr in the change here.
> --- a/tools/misc/xen-ucode.c
> +++ b/tools/misc/xen-ucode.c
> @@ -17,6 +17,15 @@ static xc_interface *xch;
> static const char intel_id[] = "GenuineIntel";
> static const char amd_id[] = "AuthenticAMD";
>
> +static void usage(const char *name)
> +{
> + printf("%s: Xen microcode updating tool\n"
> + "Usage: %s [microcode file] [options]\n"
> + "Options:\n"
> + "show-cou-info show CPU information and exit\n",
> + name, name);
> +}
> +
> static void show_curr_cpu(FILE *f)
> {
> int ret;
Without a caller this is going to cause a compiler warning (unused static
function) and, with -Werror, a build failure.
Jan
