On 07/03/2024 1:03 pm, Ross Lagerwall wrote: > On Thu, Mar 7, 2024 at 12:16 PM Andrew Cooper <andrew.coop...@citrix.com> > wrote: >> On 07/03/2024 11:58 am, Jan Beulich wrote: >>> On 07.03.2024 12:31, Andrew Cooper wrote: >>>> The thing called virtual_region already describes 6 ranges, and I'm >>>> adding a 7th. >>> Hmm, yes, in a way you're right. >>> >>>> It has been a module-ish description right from the very outset. I >>>> don't think it is fair to describe this as an abuse at all. >>>> >>>> Is this going to satisfy the outstanding concerns? >>> Yes. And thank you for bearing with me. >> No problem. I'm glad that we've come to an agreement. >> >> Ross? >> > Yes, I think that is fine with the additional description clarifying it. > > With that, > > Reviewed-by: Ross Lagerwall <ross.lagerw...@citrix.com>
Thanks. It occurs to me that this comment is best in patch 1, which is the patch that removes the final trace of this looking like a single thing. ~Andrew
