On 07/03/2024 11:58 am, Jan Beulich wrote: > On 07.03.2024 12:31, Andrew Cooper wrote: >> >> The thing called virtual_region already describes 6 ranges, and I'm >> adding a 7th. > Hmm, yes, in a way you're right. > >> It has been a module-ish description right from the very outset. I >> don't think it is fair to describe this as an abuse at all. >> >> Is this going to satisfy the outstanding concerns? > Yes. And thank you for bearing with me.
No problem. I'm glad that we've come to an agreement. Ross? ~Andrew > > Jan > >> diff --git a/xen/include/xen/virtual_region.h >> b/xen/include/xen/virtual_region.h >> index d05362071135..9d150beb8a87 100644 >> --- a/xen/include/xen/virtual_region.h >> +++ b/xen/include/xen/virtual_region.h >> @@ -9,6 +9,12 @@ >> #include <xen/list.h> >> #include <xen/symbols.h> >> >> +/* >> + * Despite it's name, this is module(ish) description. >> + * >> + * There's one region for .text/etc, one region for .init during boot only, >> + * and one region per livepatch. >> + */ >> struct virtual_region >> { >> struct list_head list; >> >> ~Andrew