On 14.02.2024 10:54, Oleksii wrote: > On Mon, 2024-02-12 at 16:03 +0100, Jan Beulich wrote: >> On 05.02.2024 16:32, Oleksii Kurochko wrote: >>> As [PATCH v6 0/9] Introduce generic headers >>> ( >>> https://lore.kernel.org/xen-devel/cover.1703072575.git.oleksii.kuroc...@gmail.com >>> /) >>> is not stable, the list in asm/Makefile can be changed, but the >>> changes will >>> be easy. >> >> Or wait - doesn't this mean the change here can't be committed yet? I >> know the cover letter specifies dependencies, yet I think we need to >> come >> to a point where this large series won't need re-posting again and >> again. > We can't committed it now because asm-generic version of device.h, > which is not commited yet. > > We can drop the change " generic-y += device.h ", and commit the > current one patch, but it sill will require to create a new patch for > using of asm-generic/device.h. Or as an option, I can merge "generic-y > += device.h" into PATCH 29/30 xen/riscv: enable full Xen build. > > I don't expect that the of asm-generic headers will changed in > riscv/include/asm/Makefile, but it looks to me that it is better to > wait until asm-generic/device.h will be in staging branch. > > > If you have better ideas, please share it with me.
My main point was that the interdependencies here have grown too far, imo. The more that while having dependencies stated in the cover letter is useful, while committing (and also reviewing) I for one would typically only look at the individual patches. For this patch alone, maybe it would be more obvious that said dependency exists if it was last on the asm-generic series, rather than part of the series here (which depends on that other series anyway). That series now looks to be making some progress, and it being a prereq for here it may be prudent to focus on getting that one in, before re-posting here. Jan
