On 25/05/18 10:49, Wei Liu wrote:
> On Fri, May 25, 2018 at 11:41:04AM +0200, Roger Pau Monné wrote:
>> On Thu, May 24, 2018 at 05:05:19PM +0100, Wei Liu wrote:
>>> They are moved to a new header which is going to be consumed by both
>>> the hypervisor and toolstack.
>>>
>>> Create a new directory for this kind of headers in anticipation of
>> ^that?
>>> more will come.
>>>
>>> No functional change.
>>>
>>> Signed-off-by: Wei Liu <wei.l...@citrix.com>
>>> ---
>>> Cc: Jan Beulich <jbeul...@suse.com>
>>> Cc: Andrew Cooper <andrew.coop...@citrix.com>
>>>
>>> Any suggestion on the directory name?
>>> ---
>>> xen/include/asm-x86/arch-shared/cpuid.h | 213
>>> ++++++++++++++++++++++++++++++++
>>> xen/include/asm-x86/cpuid.h | 210
>>> +------------------------------
>> I would have placed those inside of:
>>
>> xen/include/public/arch-x86/cpuid.h
>>
>> Protected with a #if defined(__XEN__) || defined(__XEN_TOOLS__)?
>>
> I envision this is going to grow into libcpuid or something, just like
> libelf.
I was actually considering making a libx86 or equivalent. At the
minimum, we'll need a similar split for the MSR code.
Also, making struct {cpuid,msr}_policy available to the emulation code
will drop the code volume massively, and has been on my TODO list for ages.
> Also this isn't some sort of interface between HV and toolstack -- the
> interface works on serialised data. Putting the internal representation
> in public header would be wrong.
+1
We happen to want to share some code between Xen and libxc, but it
doesn't want to be in any kind of public interface.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
